Closed juzen2003 closed 7 months ago
Attention: 102 lines
in your changes are missing coverage. Please review.
Comparison is base (
f383168
) 78.21% compared to head (643b6d4
) 77.21%.
Files | Patch % | Lines |
---|---|---|
pdsfile/pds4file/rules/pytest_support.py | 3.94% | 73 Missing :warning: |
pdsfile/pds3file/rules/pytest_support.py | 62.33% | 26 Missing and 3 partials :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Updates:
pdsfile/general_helper.py
, all the helper functions (including checking forPDS_HOLDINGS_DIR
andPDS4_HOLDINGS_DIR
env variables) for pytest are moved back to their corresponding helper files under tests or rules for pds3 & pds4.PDS_HOLDINGS_DIR
andPDS4_HOLDINGS_DIR
from your env variables, and restart terminalimport pdsfile
, you won't see any error, and you can instantiate pdsfile instance and call functions or properties as usual.PDS_HOLDINGS_DIR
andPDS4_HOLDINGS_DIR
and restart terminal, run./run_tests_coverage.sh
and all tests will passfrom_filespec
../import_for_tests.sh
using this branch https://github.com/SETI/rms-opus/pull/1338/files , and import will run without errors.line 216
atapps/tools/file_utils.py
toviewset = pdsfile.pdsviewable.PdsViewSet.from_dict(preview_json)
and OPUS will run fine locally./run_coverage.sh
orpython manage.py test -b
, and everything will pass