search

SETI / rms-pdsfile

pdsfile Python module
Apache License 2.0
0 stars 0 forks source link

Check pickle file ordering #6

Open rfrenchseti opened 9 months ago

rfrenchseti commented 9 months ago

From rms-webtools created by rfrenchseti: SETI/rms-webtools#30

_get_shelf in pdsfile.py is sorting the pickle files as they are read because they are coming in out of order. But Python 3 stores dictionaries in insertion order, so we need to investigate why the pickle files are out of order. It could just be that some of the files are old and were written with Python 2, in which case we can update the pickle files and remove the sort.

rfrenchseti commented 9 months ago

This is probably no longer an issue since all files have been regenerated since this issue was filed. If this is true then the sort can be removed.

rfrenchseti commented 1 month ago

All of the shelf directories appear to have been updated since early 2021. We could start by choosing some of the oldest pickle files, reading them in, and checking whether they are already sorted.