codecov[bot]
commented
1 year ago Codecov Report
Merging #5 (09bf54f) into main (0067aee) will not change coverage. The diff coverage is
n/a.
@@ Coverage Diff @@
## main #5 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 72 73 +1
Branches 13 13
=========================================
+ Hits 72 73 +1 | Files | Coverage Δ | |
|---|---|---|
| vax/__init__.py | 100.00% <ø> (ø) |
Based on Chase's recent comments, I took a look at some of the potential issues surrounding double-precision support. My conclusion is that it wouldn't be too hard to add but in fact we don't need it, because the files I thought contained 64-bit floats actually have erroneous labels--oops. In fact, all values are single precision and our tools are fine. In the process, I added a test file and new unit tests. I also changed docstring references "float4"/"complex8" to "float32"/"complex64" because the latter are the correct dtype names.