search

SF-Sudio / ServerBackup

GNU General Public License v3.0
38 stars 12 forks source link

A few suggestions :) #10

Open Shad0wolf0 opened 1 year ago

Shad0wolf0 commented 1 year ago

Hi! I have a few suggestions in mind. An option to set an interval in seconds (3600 for an hour) between each automatic backup An option whether backups should be done while there are no players on the server. An option whether backup should be made when server shuts down.

Josh65-2201 commented 1 year ago

You can use the backup timer stuff in the config it can do certain days and the hours : minutes of that day.

SF-Sudio commented 1 year ago

Hey, thanks for your suggestions!

An option to set an interval in seconds (3600 for an hour) between each automatic backup

Like @Josh-65 said, you can add any time of day in the config - so a timer would be just another option for when a backup should be created.

An option whether backups should be done while there are no players on the server.

The option for backup creations only when no players are online is not necessary in my opinion as the plugin is optimized to run without impacting server performance. But maybe you could elaborate on it. You mean that a backup should be created when the last player leaves the server, regardless of the time or should a backup be created only at a specific time and if there are no players online (so it might be skipped)?

An option whether backup should be made when server shuts down.

Backups while the server is down are not possible because all plugins are disabled when the server is shut down.

shoucandanghehe commented 1 year ago

The option for backup creations only when no players are online is not necessary in my opinion as the plugin is optimized to run without impacting server performance. But maybe you could elaborate on it. You mean that a backup should be created when the last player leaves the server, regardless of the time or should a backup be created only at a specific time and if there are no players online (so it might be skipped)?

I think he means stopp all backup when there are no players in the server, because there are no players playing, so there is not need for backup. Also, it would be better to create a backup when the last player exit the server and no player join again for a certain period of time (?).

Backups while the server is down are not possible because all plugins are disabled when the server is shut down.

Blocking when the server executes the stop command and stops blocking after creating a backup, I think (?).

tips: I also want these features :XD