SF-Sudio / ServerBackup

GNU General Public License v3.0
38 stars 12 forks source link

Every time I use plugin I get this warning #5

Closed ilfarpro closed 2 years ago

ilfarpro commented 2 years ago

Hi! Every time I use plugin I get this warning. I'm not a programmer, so can't understand, what it means. Can you please fix this, so people will see less warning and will be less worried about happeng. Also it's really important, when I start backup, there is no information about progress in console. Just saved and zipped messages. It's quite uncomfortable and makes you feel lost. image

Forget to mention, it's paper server 1.18.1

SF-Sudio commented 2 years ago

Hey, so first of all the warning you get only affects the console message. It will not affect the plugin functionality at all. Are you using the latest version of my plugin? Because I thought I have already fixed this "bug", but I will check that again before posting the next update. And to your second point: I thought it would be better to not send much messages about the progress of a backup, because otherwise you would get a lot of messages and your server log file would also get very big (depends on how many backups you create). When there is the message "Backup ["your world"] saved." your backup is 100% finished and saved - if there where any errors before you would have get an error message. But I am thinking of implementing progress messages (e.g. "Backup at 25%.", "Backup at 50%.", ... - or something like that). Would that be a good feature?

ilfarpro commented 2 years ago

Yes, I am using latest version available on spigotmc.org which is 2.5.0 (from December 11). And I still see this console warning. image Implementing progress messages would be really great. If you don't want to flood logs with messages, you can just show few messages, for example 25% 50% and 75%. It's your idea, and it's good idea :)

ilfarpro commented 2 years ago

There's actually another warning about API version, and maybe error before him related to him. image

zoeleu commented 2 years ago

@SebliYT Please, change every use of System.out.println or System.err.println to use the plugin's logger.

SF-Sudio commented 2 years ago

Issue fixed.