SFDO-Community-Sprints / transfer-equivalency-credits-eda

Open Source Community Sprint project focused on building functionality to search for course and credit transfer equivalency between institutions.
10 stars 7 forks source link

Virtual Sprint Commit Data Model Schema #34

Closed jacebryan closed 4 years ago

jacebryan commented 4 years ago

Critical Changes

Changes

Issues Closed

robertbwatson commented 4 years ago

@jacebryan @IAmEricKenney This looks great! I'm almost ready to approve and merge in, but I do have a couple of questions/comments:

1) Should new Tabs have been created for some of these new objects? (How is an admin supposed to use/set these up?) If so, I can create an Issue for someone to create them in a future sprint.

2) I uncovered a few issues with our existing test data and also other areas where I think we can make improvements. I logged these all as issues that someone might be able to work on in a future sprint:

Related to these new objects:

40 Update Entity Relationship Diagram & Use Cases

43 Update Test Data

Bugs:

42 Fix test data task (test_data_dev_org)

Other/CCI-related:

41 Update scratch org JSON configuration files

Let me know what you think. Thanks!

IAmEricKenney commented 4 years ago

@robertbwatson Yes, a couple of tabs should have been created. How should I get those added?

We created an ERD. Starley might still have it saved.

robertbwatson commented 4 years ago

@robertbwatson Yes, a couple of tabs should have been created. How should I get those added?

Thanks, @IAmEricKenney. I created #44 to get these added; they can be done in a separate pull request or at the next sprint! :)

We created an ERD. Starley might still have it saved.

Great! I've updated issue #40 with that info.

I don't want to hold up on the merge on this any longer (that way we have it for the next virtual sprint!), so I'll go ahead and merge this now.

jacebryan commented 4 years ago

Thank you both!