Prerelease refinements

[mkolodner]

Critical Changes

Changes

Some layout refinements and other things we've been working on in OCC production while Nick got this ready for packaging.

Issues Closed

[mkolodner]

@Nickers3 - Just created this pull request with items I want to add to master. You'll see that there are some things that my source_retrieve pulled down (some profiles, the email to case settings) that I know we need to drop. But wasn't sure how to do that safely. Also, I've added some things about Path that might not package up that easily. Take a look at the changes in my pull request and let me know if I can help.

[mkolodner]

@Nickers3 - Look at my note on the original commit for this branch, for example.

[Nickers3]

@mkolodner looks like some good changes. I did the deletes right within the branch so you should be able to fetch and pull down to your repo. I didn't delete the Admin one yet, but we'll want to do delete that one as well as we're only able to set default record types and page layouts for scratch orgs.

I think everything else will be fine and can merge.

On a different topic, same idea, you may have seen the post on the HUB about record types. I think it'll be best to move the account list views to unmanaged and also move the contact create quick actions to unmanaged as that will remove the dependency to any record type within the package. Are you ok with this?

[Nickers3]

@mkolodner one thing I did notice were the new email templates. I'd recommend creating an OCC folder for those. If you hit issues creating and pulling, let me know.

[mkolodner]

@Nickers3 No problem with dealing with the record types as you say. (Just that I don't know how to do it.) Created the folder for email templates and moved them into it. It looks like the folder and templates came down in this commit, but perhaps duplicated?

[Nickers3]

@mkolodner it does look like the extra templates were created, I deleted the public folder emails.

Also, I noticed there was an email to case settings. Did that come down because you were doing related items or were you wanting to keep?

[mkolodner]

@Nickers3 That email to case setting is not something we need to keep. I think it has to be enabled before emails will go out, but that's an org setting we wouldn't be packaging. That reminds me, though: Is there a way to set two scratch org settings just to save time:

1. Under Session Settings, turn off persistent caching. This has nothing to do with packaging, just everything to do with making it easier to work in the scratch org. I assume there is some way to set projects to have this setting of scratch orgs become my default. (Honestly, it should be everyone's default for scratch orgs, I would think.)
2. Similarly, can I set the default scratch org length (in days)? I see little downside to always setting my scratch orgs to last 30 days, since I'm likely to delete them sooner. But if I make them more persistent, I could try to get the other OCC collaborators to log into them and work on them with me.

[Nickers3]

@mkolodner the session settings may be able to be changed via the unmanaged/config. For scratch org length, it can be changed via: https://cumulusci.readthedocs.io/en/latest/features.html?highlight=org%20length#scratch-org-configs.

It's best practice to keep scratch orgs up for a limited time to always be getting the most up to date branch. That said, I could see setting one org for 30 days for group collaboration.

[mkolodner]

I think you're right on both scores. I don't really know how to put that unmanaged/config change into the repo, though. I'll try poking around a bit to see if I can figure it out. As for scratch org length, we're on the same page. BTW - I just tried creating an org from this pull request and it failed because the folder for the email templates wasn't there. I edited the folder and tried to retrieve changes, but I don't think it came down. I'm trying again, but see if you are able to successfully create a scratch org from this pull request?

[Nickers3]

@mkolodner I think I have the security settings added now. Creating a new scratch org to check your comment on the email templates. I think you're right though, it's doesn't seem to be included in the repo. Did you create a classic folder? Or are these in Lightning?

[mkolodner]

Classic email templates in a Classic folder.

[Nickers3]

@mkolodner should work for you now. For some reason the new folder you had created didn't end up in the repo. I set the folder to read only. Does that work for you?

[mkolodner]

Should be fine. I'm testing it now.

[mkolodner]

@Nickers3 I got an error on the dataset load:

2020-06-09 15:00:29: Prepared 24 rows for insert to Contact 2020-06-09 15:00:29: Uploading batch 1 2020-06-09 15:00:31: Waiting for job 750J0000005S0oyIAC (1/1 batches complete) 2020-06-09 15:00:32: Job 750J0000005S0oyIAC finished with result: Row failure 2020-06-09 15:00:32: Downloaded results for batch 751J00000055uDfIAI 2020-06-09 15:00:32: Exception in task config_qa.load_dataset

Error: Error on record with id 003P000001NAjsPIAT: INVALID_CROSS_REFERENCE_KEY:Record Type ID: this ID value isn't valid for the user: 012J00000010r5oIAA:RecordTypeId -- Run this command for more information about debugging errors: cci error --help

[Nickers3]

@mkolodner try running cci task run update_admin_profile and retry after. I haven't had issues creating new orgs this week.

[mkolodner]

Is it possible to throw the update_admin_profile into the flow somewhere? Otherwise, I think I'll have to:

1. Run the dev_org flow.
2. Metadata will succeed, but then dataset insert fail part way through.
3. Delete all the records that were created.
4. Run update_admin
5. Run the dataset insert flow again.

[Nickers3]

@mkolodner it currently is included with the dev_org flow. Wanted to have you rerun to trouble shoot.

1) flow: dependencies [from current folder] 1) task: update_dependencies 2) task: deploy_pre 2) flow: deploy_unmanaged 0) task: dx_convert_from when: project_config.projectsource_format == "sfdx" and not org_config.scratch 1) task: unschedule_apex 2) task: update_package_xml when: project_config.projectsource_format != "sfdx" or not org_config.scratch 3) task: deploy when: project_config.projectsource_format != "sfdx" or not org_config.scratch 3.1) task: dx_push when: project_config.projectsource_format == "sfdx" and org_config.scratch 4) task: uninstall_packaged_incremental when: project_config.project__source_format != "sfdx" or not org_config.scratch 3) flow: config_dev 1) task: deploy_post 2) task: update_admin_profile 3) task: deploy_dev_config 4) task: load_dataset 4) task: snapshot_changes

[mkolodner]

@Nickers3 Worked this time. Not sure what was different. I'll poke around a bit in the created scratch org and either let you know or else merge into Master.

[Nickers3]

@mkolodner sounds good. I am making a couple more changes as we speak. The main items are moving the account record type dependencies to unmanaged. Creating a new scratch org to test to make sure it works first before committing.

[mkolodner]

@Nickers3 - I have one change that I wanted to push but it looks like a lot of garbage came down with it. The change is to add the email template (Sample Email Case to Command) to the Send Case to Command quick action on Case. But when I made that change and then pulled it down, I've now got 228 changed files. Looks like a ton of them are fields on standard objects, not to mention profiles, etc. I don't want to send a commit with all that garbage. What do you recommend?

[Nickers3]

Thanks for the reminder on the forceignore. Keep meaning to update. May not get to it until Thursday.

On Tue, Jun 9, 2020, 5:38 PM Michael Kolodner notifications@github.com wrote:

@Nickers3 https://github.com/Nickers3 - I have one change that I wanted to push but it looks like a lot of garbage came down with it. The change is to add the email template (Sample Email Case to Command) to the Send Case to Command quick action on Case. But when I made that change and then pulled it down, I've now got 228 changed files. Looks like a ton of them are fields on standard objects, not to mention profiles, etc. I don't want to send a commit with all that garbage. What do you recommend?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/SFDO-Community-Sprints/OmbudsmanCloudCare/pull/28#issuecomment-641617616, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACUVOYXA473G2LMML6R5F2LRV22UZANCNFSM4NYW65CQ .

[mkolodner]

No worries—thanks for all you’re doing. I don’t know how I would do this on my own.

————————- Michael Kolodner michael@kolodner.com Find a time to meet with me.

On Jun 9, 2020, at 7:05 PM, Nickers3 notifications@github.com wrote:

 Thanks for the reminder on the forceignore. Keep meaning to update. May not get to it until Thursday.

On Tue, Jun 9, 2020, 5:38 PM Michael Kolodner notifications@github.com wrote:

@Nickers3 https://github.com/Nickers3 - I have one change that I wanted to push but it looks like a lot of garbage came down with it. The change is to add the email template (Sample Email Case to Command) to the Send Case to Command quick action on Case. But when I made that change and then pulled it down, I've now got 228 changed files. Looks like a ton of them are fields on standard objects, not to mention profiles, etc. I don't want to send a commit with all that garbage. What do you recommend?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/SFDO-Community-Sprints/OmbudsmanCloudCare/pull/28#issuecomment-641617616, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACUVOYXA473G2LMML6R5F2LRV22UZANCNFSM4NYW65CQ .

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

[Nickers3]

@mkolodner noticed you added the security settings again. Did the setup I have not go through?

[mkolodner]

Not sure if your setup went through or not. (I'm not clear on how to check or what I'd be checking for.) Sorry for pushing that incorrect setting. I expect it's something I got wrong.

[mkolodner]

Other than the fact of the security settings I inadvertently added, which I'll let you fix up @Nickers3 , this branch looks great to me and is ready to merge into Master.

[Nickers3]

I'll have to take a closer look at the picklist fields tomorrow. Wonder if it's similar to the branding where it's sending it and shows as a false positive.