search

SFDO-Community / OmbudsmanCloudCare

App for Navy ombudsmen to track, resolve, and report on cases.
BSD 3-Clause "New" or "Revised" License
10 stars 5 forks source link

Time tracking #42

Closed mkolodner closed 4 years ago

mkolodner commented 4 years ago

Critical Changes

Adds time tracking to Tasks (Activities) via one picklist and a formula field.

Changes

Adds an OCC Task page layout that includes Time Spent picklist. Adds three reports and a dashboard for time spent on tasks. Dataset also updated to include time values on tasks.

Issues Closed

mkolodner commented 4 years ago

@Nickers3 - I'm not merging this pull request on my own because there could be implications for some of your work on packaging. We have added a field on Task (Activity) for how long was spent. This means there is need for a page layout change and--probably an issue to discuss update to any of the quick actions that get used to create Tasks. I don't know if we will be able to package that update or if it will have to be a post-install step. Either way, you should look at what's in this pull request and think about whether things have to move to unpackaged...

Nickers3 commented 4 years ago

@mkolodner there shouldn't be too much of an issue with the packaging from this change. Since the first version was getting errors, we should be able to create a new version and the changes flow through.

I did notice there being two Task layouts - Task-Task Layout.layout-meta.xml and Task-OCC Task Layout. Did we mean to have two? Also, there was an Event layout. I'd recommend using the OCC naming convention we've done elsewhere.

Nickers3 commented 4 years ago

Big renames such as Home to Help and Training are fine for now. Once we have a working package, we'll want to avoid renaming the API Name for those.

mkolodner commented 4 years ago

@Nickers3 - That's not a rename. I added a second tab/Lightning App Page. Home is still Home. There's also a Help and Training flexipage.

mkolodner commented 4 years ago

Agree with you about the OCC naming convention for both Task and Event. It might actually be easier to NOT package an OCC layout for either of those and just have a post-install task of adding the Time Spent field. That won't really take any more time than changing the page layout assignment (which they'll still have to do.)

Nickers3 commented 4 years ago

For the tasks/events, are there any other changes to those objects? I remember seeing some quick actions if I'm not mistaken. Packaging would be a way to include all.

mkolodner commented 4 years ago

This gets into a question about how to pull this off most effectively: We've added just one field on the page layout (and a formula field that isn't). But most of the time Tasks are not created using the page layout, they're created via the global quick action or the Log A Call or New Task quick actions. We want to add that field to those quick actions. (I think it's those changes that got pulled down.) But I doubt we can actually modify the existing quick actions, even with unmanaged, right? So I suspect we might have to create and package our own Quick Action, which we then put on the Case and Contact page layouts, etc...

Nickers3 commented 4 years ago

I'd be fine leaving the task and event page layouts out. Page layouts don't update when new versions come out so I'd be fine keeping out.

mkolodner commented 4 years ago

Agree--take them out. (I'm not sure how to accomplish that in GitHub, so can I ask you to do it?) I'm putting the instruction in my post install doc (https://docs.google.com/document/d/1e2zoWwjPJv9DVSV4MG8rRX_dv4yxXHdLQWeDcJNNSLE/edit#).