Closed Nickers3 closed 4 years ago
@mkolodner I think I have everything ready for the Command Name deletion. I got a bit into the unpackaged directories and did some structural changes. Shouldn't change what appears in orgs. More trying to achieve what will be in the various orgs - customer, developer, all.
Awesome!
@Nickers3 - I've got this pull request in VSCode and I'm spinning up an org using install_managed (so that I can see for sure how the Command Name field works in this version). But in your email you had mentioned using the dev_org flow to test. If I did that flow, Command Name would be editable (since it would all be unmanaged), so you've got me confused. Is there something else you want me to be testing with a dev_org flow?
@mkolodner use the dev_org flow. We haven't pushed this change to the packaging org so we need to test using dev_org to make sure everything works. Everything mostly means the unpackaged components - standard value sets, profiles, and branding all deploy.
Once we confirm this test, we can merge into master and produce a new package version to test the old field is gone and new field appears via install_managed.
@Nickers3 - I did one version using dev_org and everything there looks good. Since I also already had a version going using install_managed, I also let that one finish. In that one I saw two Command Name fields, one with namespace and one without. So I think that also is good. I think this is ready to merge to master.
Groovy! Mark your review as complete. Then when we hear back from Jason regarding the feature test, we can merge to master.
Nickers nick@stlf.net
On Mon, Jul 20, 2020 at 12:37 PM Michael Kolodner notifications@github.com wrote:
@Nickers3 https://github.com/Nickers3 - I did one version using dev_org and everything there looks good. Since I also already had a version going using install_managed, I also let that one finish. In that one I saw two Command Name fields, one with namespace and one without. So I think that also is good. I think this is ready to merge to master.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/SFDO-Community/OmbudsmanCloudCare/pull/81#issuecomment-661228184, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACUVOYRAABS3F2AZQNQZHR3R4R6GJANCNFSM4OZ27TVA .
Critical Changes
-Move Command Name on Sailor Object to unpackaged -Remove Command Name from dependent metadata -Create customerorg directory for items only going into customerorgs
Changes
-Restructure unpackaged to simpify package xml files -Update cumulusci.yml to simplify tasks.
Issues Closed
71