search

SFDO-Community / OmbudsmanCloudCare

App for Navy ombudsmen to track, resolve, and report on cases.
BSD 3-Clause "New" or "Revised" License
10 stars 5 forks source link

Remove Lead Source Picklist Values #83

Closed Nickers3 closed 4 years ago

Nickers3 commented 4 years ago

Critical Changes

Remove Lead Source from Picklist values

Changes

Issues Closed

Nickers3 commented 4 years ago

@mkolodner made the change real quick. Running a test via metaci to see if things work now: https://sfdo-community-ci.herokuapp.com/builds/2948

mkolodner commented 4 years ago

I was also working on a test with what I expect is the same change.

Nickers3 commented 4 years ago

Outside of deleting the lead source lines, I also added Mx as a Salutation option as that wasn't included before.

mkolodner commented 4 years ago

It looks like my test worked. But since mine was not from an entirely clean org (I re-ran dev_org on the demo org that had the error), it's probably best to ensure that yours works from scratch.

Nickers3 commented 4 years ago

Mine was a success too so I think we're good to go here. I'll assign you as the reviewer since you did the test via the demo org.

Nickers nick@stlf.net

On Fri, Jul 17, 2020 at 3:04 PM Michael Kolodner notifications@github.com wrote:

It looks like my test worked. But since mine was not from an entirely clean org (I re-ran dev_org on the demo org that had the error), it's probably best to ensure that yours works from scratch.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/SFDO-Community/OmbudsmanCloudCare/pull/83#issuecomment-660313253, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACUVOYR5DNXYTJOSFSZ6TY3R4CVETANCNFSM4O6ZIL6Q .

mkolodner commented 4 years ago

Looks good to me. But I don't seem to have the ability take any action. I can click "Close and comment," which seems like it would close the issue. But I've got a message that merging is blocked because a test hasn't been completed yet. However, I don't see how to do the "Feature Test" check.

Nickers3 commented 4 years ago

@jlantz we are working through our first branch and noticed the feature test didn't get a result back. Is this something you'd be able to look into this week?

Nickers3 commented 4 years ago

Looks like I can trigger a feature test via MetaCI so I will run that here.

Nickers3 commented 4 years ago

@mkolodner I was able to manually get this branch to pass the feature test too via metaci. Mind confirming the contact record types work as expected on this branch before we merge.

mkolodner commented 4 years ago

Ran it with dev_org flow and the record types look right. (They exist and are assigned to the sysadmin profile.) Not sure if there is something else I should be looking for. I'm also trying to run it as install_prod in another org. But that's taking forever.