search

SFDO-Community / Salesforce-Indicators

Indicators Lightning Web Component
https://github.com/SFDO-Community-Sprints/Salesforce-Indicators/wiki
BSD 3-Clause "New" or "Revised" License
62 stars 19 forks source link

SLDS Spacing seems to have changed #132

Closed JodieM closed 8 months ago

JodieM commented 1 year ago

Tiny little thing, but it is annoying as it looks inconsistent.

In Winter 24 the spacing above and below the card text seems to be less than previous. The code has not changed, But the card text is now squashed up against the icons.

I would like there to be similar vertical whitespace between the card text and the icons as there is between the icons.

Screenshots The Screenshots show the differences between a previous version (probably Spring '23 before the icon colors changed) and Winter '24. Snag_2a2807d3 Snag_2a28105f

Code Notes The code for the card text is 

<p class="slds-var-p-horizontal_medium">{card.body}</p>
<div class="slds-var-m-left_medium">

Winter '24 SLDS is not out yet but there is an inconsistency in the around class where _medium is 0.5rem whereas top, bottom and vertical are 0.5rem and left, right, and horizontal are 0.75rem. So it will have to be class="slds-var-p-horizontal_medium slds-var-p-vertical_medium" rather than the more simple class="slds-var-p-around_medium"

The Icon and space between the Icon and heading are also different than previous and would look a little better if they were like previous.

Also the bundle Icon is much bigger than previous and it needs to be sized smaller.

Desktop (please complete the following information):

Additional context This org is on Hyperforce

JodieM commented 10 months ago

Made some minor changes due to inconsistencies in the documentation vs how it renders, but fixed in feature/contains-equals