Aug23 fixes

[tcdahlberg]

Critical Changes

Changes

• Fixed confirmation page so that if payment is received the balance shows zero
• Formula on Event Instance now shows start/stop time when close to 12
• On the guest registration if the user has entered guest information but has not added that information to the guest list a modal pops up asking "You have unsaved Guest information entered. Select Cancel to finish adding your guests." language for this pop up is configurable via new labels in the event object.
• Additional questions on the event page and on the question object now have an additional long text field for creating longer picklists. This new field can be used in addition to or to replace the old field that was a textarea with 255 characters limiting the pick list.
• Additional label fields were added to the event fee section of the event object to allow for a configurable heading if payment was received or payment was due and an opportunity to add a rich tech description underneath the heading.
• Various bug fixes

Issues Closed

• Closes #517
• Closes #516
• Closes #514
• Closes #513
• Closes #512
• Closes #511
• Closes #495
• Closes #446
• Closes #519

[tcdahlberg]

I am still testing through a throw away package version in conjunction with a gateway to make sure payments flow through when a gateway is set up. All the above can be test through without a gateway though.

[tcdahlberg]

I tested the a feature/throw away package in my touchnet project and the package worked as expected.

[rdblake21]

✅ #446 ✅ #495 - Updated Page layout and pushed to PR ✅ #511 ⚠ #512 - This works, but the error leaves no context. Please add "Please enter a valid 4-digit value" @tcdahlberg @walt0019 ✅ #513 ✅ #514 ✅ #516 ☑ #517 - Unable to test based on payments process @tcdahlberg

@tcdahlberg All bug testing passed, but I made a note above on #512. please review and let me know if you have questions.

[tcdahlberg]

@rdblake21, I added the error message you suggested to the preferred class year question.

[rdblake21]

@tcdahlberg Thanks for the update. Looks good, but I think we need to update the logic. Right now, the error message only shows for "Ask and Require", but if the question is set to "Ask", the error doesn't display at all. We should always have the error context to ensure data quality and an explanation, even if we don't require it. The "Ask" should operate as it does now, clearing out the error field, but highlight in red and show the error message (like Ask & Require does), but then should the registrant not enter a value, they should be able to continue with a blank value, which is the current experience.

So the only item to update is that ANY time the Preferred Class Year is asked, it should always reflect the error message.

I would update the apex, but I'm not sure how to do it as it isn't an IF statement anymore. I don't know that we need the logic based on the field value as the error should just show.

[tcdahlberg]

@rdblake21, I almost pushed back on the preferred class year requirement because technically it is a new way to display help text and required some work. Short story, I went ahead and made it.

Most of this validation is done on front-end javascript so it's not really in the visualforce page. validYear is a particularly heavy validation since it validates on key down and on change. I didn't like the look of it being required, so I built out a semi-error state for not required called slds-has-info. When not required this will show the help text and bold the outline of the input.

There is a lot of hard code "This field is required" on the page. We should probably create a default label for the required field and let the event manager choose what that says. Next release?

I also fixed #519 because I was in that code and it was an easy win.

[rdblake21]

@tcdahlberg This all looks really good and I agree with you on the user experience for something that's not required.

I hear what you're saying on the default label for a required field, however, I don't know that we've had feedback on it being an issue. It seems relatively standard, IMO, and there is additional custom error handling on the Custom Questions object. Please disagree with me, but I'm hesitate to create an issue and another field label when we have functionality to drive individuals to creating custom questions.