SFDO-Community / declarative-lookup-rollup-summaries

Declarative Lookup Rollup Summaries (DLRS) is a community built and maintained Salesforce application that allows you to create cross object roll-ups declaratively - no code! For install instructions and documentation, visit our website https://sfdo-community-sprints.github.io/DLRS-Documentation/

https://sfdo-community-sprints.github.io/DLRS-Documentation/

BSD 3-Clause "New" or "Revised" License

683 stars 235 forks source link

Updated API versions from v58.0 to v59.0 #1397

Closed groundwired closed 8 months ago

groundwired commented 8 months ago

Critical Changes

RollupDmlGuard API version updated to v58.0

Changes

No code changes - just version updates in two files that were missed

Issues Closed

https://github.com/SFDO-Community/declarative-lookup-rollup-summaries/issues/1396

salesforce-cla[bot] commented 8 months ago

Thanks for the contribution! Before we can merge this, we need @groundwired to sign the Salesforce Inc. Contributor License Agreement.

aheber commented 8 months ago

This is great but it is actually time to bring everything up to API V59.0, would you be willing to change this to V59.0?

If you can cleanup the extra file and sign the CLA that should be everything we need to accept this! Really appreciate you bringing a problem and a solution.

groundwired commented 8 months ago

This is great but it is actually time to bring everything up to API V59.0, would you be willing to change this to V59.0?

If you can cleanup the extra file and sign the CLA that should be everything we need to accept this! Really appreciate you bringing a problem and a solution.

@aheber Should be all set!

aheber commented 8 months ago

This looks great, thank you for expanding it! You even caught all the non-xml versions that most people miss.

I'll have to figure out what we need to do to get the automated tests to run so we can accept this. I think we might need to recreate the branch inside the team-scope but I'll get back to you on that.

groundwired commented 8 months ago

This looks great, thank you for expanding it! You even caught all the non-xml versions that most people miss.

I'll have to figure out what we need to do to get the automated tests to run so we can accept this. I think we might need to recreate the branch inside the team-scope but I'll get back to you on that.

That seems wise! FWIW, I did run all Apex tests in the package in my scratch org. Everything passes.

aheber commented 8 months ago

@groundwired I think you should have received an invite to join the project. That should allow you to close this PR and your branch under your name. Push these changes to a branch directly on the project an open a new PR. That will allow the automation to run and validate your changes and get the needed passes so we can merge.

Sorry for the trouble but hopefully it isn't a lot of work.