SFDO-Community / declarative-lookup-rollup-summaries

Declarative Lookup Rollup Summaries (DLRS) is a community built and maintained Salesforce application that allows you to create cross object roll-ups declaratively - no code! For install instructions and documentation, visit our website https://sfdo-community-sprints.github.io/DLRS-Documentation/
https://sfdo-community-sprints.github.io/DLRS-Documentation/
BSD 3-Clause "New" or "Revised" License
689 stars 237 forks source link

Autocomplete Combobox Enhancements #1432

Closed octatau closed 7 months ago

octatau commented 7 months ago

Critical Changes

Changes

aheber commented 7 months ago

Thanks! I'll be able to take a look in the morning.

aheber commented 7 months ago

In objectSelector.js I think there are a bunch of properties that we don't use anymore. Things like iconName, selectedIconName, delayTime and a few others. If you want to clean those up now that would be great or we can merge this and then clean those up on the next round of review.

This looks great and seems to be working through my tests. Awesome work!

aheber commented 7 months ago

I know you have it on your todo list but if the icon loads late, it should back-fill the selection. (Object selector used to have it)