Upgrade all SFDX Commands to SF Commands

SFDO-Tooling / CumulusCI

Python framework for building portable automation for Salesforce projects

http://cumulusci.readthedocs.io

BSD 3-Clause "New" or "Revised" License

356 stars 241 forks source link

Upgrade all SFDX Commands to SF Commands #3621

Open GeekStewie opened 1 year ago

GeekStewie commented 1 year ago

Feature Type

I'm interested in functionality that solves a current problem or limitation in how CumulusCI works.

Does your feature request solve a current problem?

I noticed this in the SFDX update today:

IMPORTANT ANNOUNCEMENT, PLEASE READ: We no longer update sfdx (v7); the last stable version is 7.209.6. You can keep using sfdx (v7) if you want, but it won't contain new features or bug fixes. And we no longer update this page.

And looking at the installers, it now defaults to the SF CLI when you install via npm etc.

I know we have had warnings for a while now but looks like the move needs to happen to ensure we are not using unsupported CLIs

Describe the solution you'd like

Migrate all SFDX commands within CumulusCI to SF equivalents

Describe alternatives you've considered

No response

Additional context

No response

jstvz commented 1 year ago

Initial work tracked in W-13772594.

mattmartin26 commented 10 months ago

Would really appreciate an update on this, our CTO is considering moving away from CumulusCI depending on if/how soon CCI will transition from SFDX to SF.

jlantz commented 10 months ago

I'm no longer part of the team, but I do want to clarify the message from @GeekStewie's original post. The deprecation message is that they are no longer maintaining the sfdx package itself. The new sf cli package continues to ship with sfdx though. They just don't want you to install the old sfdx package directly anymore. CumulusCI still works fine against the new sf cli installers since they include sfdx.

The warnings call out a few places where CumulusCI's code needs to be updated to use the new commands and environment variables. I'd love to see them gone to avoid this confusion, but I'm reassured knowing that Salesforce is actively using CumulusCI. The Architecture Decision Record (ADR) discussion for this is available at in PR #3630

CumulusCI is actively built against test projects via GitHub Actions including full packaged builds against a test project. Any failures would be pretty quickly detected by those builds.

davisagli commented 10 months ago

@jlantz It looks like the Github Actions need to be updated to install sf rather than sfdx, though: https://github.com/SFDO-Tooling/CumulusCI/blob/main/.github/workflows/feature_test.yml#L77

jlantz commented 10 months ago

@davisagli Great point. That's an easy PR that I'll put together shortly as an early warning system at least.

jstvz commented 10 months ago

@mattmartin26 Thanks for flagging this. Here's a quick update on the SFDX to SF CLI transition:

We've started work to migrate SFDX commands in CumulusCI to SF. It's on our radar. For details, check out the discussion on the proposed ADR in #3630 (feedback welcome).
As @jlantz mentioned, the new sf CLI still ships with sfdx, commands will still function as expected despite the warnings.
We're adjusting our GitHub Actions per @davisagli's spot, to reflect the ongoing changes.

georgeslater commented 2 months ago

The latest CLI release candidate's release notes states that the force:org:create command will stop working on November 6th, 2024. Is that something to be concerned about?