SFDO-Tooling / CumulusCI

Python framework for building portable automation for Salesforce projects
http://cumulusci.readthedocs.io
BSD 3-Clause "New" or "Revised" License
359 stars 242 forks source link

Deleted Versions used for determining next version #3746

Open yippie opened 7 months ago

yippie commented 7 months ago

Describe the bug

create_package_version._get_base_version_number() does not filter out deleted package versions IsDeprecated=true this means if you ever accidentally make a higher version number, create_package_version will keep trying to make much larger version numbers than desired or expected.

Please add the filter IsDeprecated=true to the version query to match what is seen in sf package version list

Reproduction steps

  1. Create version 1.0.0 and version 2.0.0 of a package
  2. Delete 2.0.0 with sf package version delete command
  3. Run cci task run create_package_version to make a new package version

Expected: Version 1.0.0.NEXT created

Actual: Version 2.0.0.NEXT is created instead.

Your CumulusCI and Python versions

CumulusCI version: 3.84.1 (/Users/kai.amundsen/.local/bin/cci) Python version: 3.10.9 (/Users/kai.amundsen/.local/pipx/venvs/cumulusci/bin/python)

Operating System

macOS Sonoma 14.1.1

Windows environment

No response

CumulusCI installation method

pipx

Error Gist

No response

Additional information

No response