SFDO-Tooling / MetaDeploy

Salesforce.org's managed package installer
https://install.salesforce.org
BSD 3-Clause "New" or "Revised" License
46 stars 47 forks source link

Installation Errors with products that extend a public managed package (EDA) #3500

Closed FranciscoJOlmos closed 1 year ago

FranciscoJOlmos commented 1 year ago

I have a managed package that we built on top of EDA, and I added it to our instance of MetaDeploy. I'm getting errors when testing the install.

https://aka-metadeploy.herokuapp.com/products/CourseCalendar/1.0/install/jobs/XkDYPzZ

image

I don't know if this helps, but we had a similar issue when we first started working with Metecho.

davidmreed commented 1 year ago

Hi @FranciscoJOlmos - I love that you're using MetaDeploy to ship EDA extensions!

Unfortunately, this is something that there's no real fix for, and it goes to how GitHub App permissioning works. GitHub requires that your GitHub App be installed in the EDA repo, even though EDA is actually open source. We cannot install your app in our repo, however

I have a general recommendation, though, that you should refrain from installing parent products in your own installer. The reason for that is that your customer may have customized, for example, the EDA unmanaged metadata. If you re-deliver that metadata, you'll overwrite their changes.

Instead, I recommend using a preflight check to validate that EDA is installed, and not include the update_dependencies task in your installer plan.