search

SFDO-Tooling / Snowfakery

A tool for generating fake data that has relations between tables.
BSD 3-Clause "New" or "Revised" License
141 stars 32 forks source link

Updated to Pydantic 2 (superset of Jason's) #1030

Open prescod opened 5 months ago

prescod commented 5 months ago

Obsoletes #1018

prescod commented 5 months ago

@jstvz

The current test failure is because CCI is on Pydantic 1 while Snowfakery is on Pydantic 2.

Do you want to:

a) upgrade CCI and Snowfakery to Pydantic 2 in a single coordinated release or

b) support Pydantic 1 and 2 simultaneously in Snowfakery so that they can upgrade in a staggered manner?

prescod commented 5 months ago

Obviously b) involves ugly cruft that will need to be removed eventually.

jstvz commented 4 months ago

@jstvz

The current test failure is because CCI is on Pydantic 1 while Snowfakery is on Pydantic 2.

Do you want to:

a) upgrade CCI and Snowfakery to Pydantic 2 in a single coordinated release or

b) support Pydantic 1 and 2 simultaneously in Snowfakery so that they can upgrade in a staggered manner?

Option (a) is my preference.

prescod commented 4 months ago

@jstvz . Okay, ping me when the time comes if there are challenges on the Snowfakery side. It actually doesn’t thave a lot of Pydantic stuff in it and arguably what it does have should move to the CCI repo because it relates to CCI.