SFDigitalServices / formio-sfds

The form.io theme for sf.gov
https://formio-sfds.herokuapp.com/
MIT License
15 stars 2 forks source link

Improve vertical rhythm #118

Closed shawnbot closed 4 years ago

shawnbot commented 4 years ago

This is an attempt to clean up after some of the changes in #106 degraded a couple of our live forms. (The form I'm looking at has some design problems in the form spec itself, but those will be harder to fix, IMO.) The proxy preview continues to be useful for testing, and for longer forms I've improved the panel component templates so that we can use renderMode: 'flat' to force the form out of "wizard" mode and see everything at once. Links to test:

/cc @aekong @nlsfds

vercel[bot] commented 4 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/sfds/formio-sfds/c5yi8y7s9
✅ Preview: https://formio-sfds-git-vertical-rhythm.sfds.vercel.app

github-actions[bot] commented 4 years ago

Size Change: -60 B (0%)

Total Size: 91.6 kB

Filename Size Change
dist/formio-sfds.css 14 kB -20 B (0%)
dist/formio-sfds.standalone.js 67.4 kB -40 B (0%)
ℹī¸ View Unchanged | Filename | Size | Change | | |:--- |:---:|:---:|:---:| | `dist/common.css` | 484 B | 0 B | | | `dist/examples.js` | 3.71 kB | 0 B | | | `dist/examples/example.js` | 683 B | 0 B | | | `dist/portal.js` | 5.39 kB | 0 B | |

compressed-size-action

aekong commented 4 years ago

renderMode: 'flat'! 🎉