SFDigitalServices / formio-sfds

The form.io theme for sf.gov
https://formio-sfds.herokuapp.com/
MIT License
15 stars 2 forks source link

Fix well validation issues #119

Closed shawnbot closed 4 years ago

shawnbot commented 4 years ago

@nlsfds and I discovered a very strange issue when testing the 6.3.0 release with this form. To reproduce it:

  1. Load up the proxy preview of 6.3.0 with the form
  2. On the "About you" page, select "Attorney in fact" (or, I believe, any option except "Owner")
  3. Fill in the remaining required fields to proceed to the next page
  4. On the "Project team" page, click the "Next" button. You should see an odd state in which none of the fields are marked as invalid, but the error list appears below:

    image

I don't know why this is happening, but my hunch is that we're rendering improperly nested HTML in one or more of our templates, and changing well components to render <section> elements provides a better "hint" to HTML parsers that the element is closed.

vercel[bot] commented 4 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/sfds/formio-sfds/i63jr27u7
✅ Preview: https://formio-sfds-git-fix-well-validation.sfds.vercel.app

github-actions[bot] commented 4 years ago

Size Change: -46 B (0%)

Total Size: 91.6 kB

Filename Size Change
dist/formio-sfds.css 14 kB -13 B (0%)
dist/formio-sfds.standalone.js 67.4 kB -33 B (0%)
ℹ️ View Unchanged | Filename | Size | Change | | |:--- |:---:|:---:|:---:| | `dist/common.css` | 484 B | 0 B | | | `dist/examples.js` | 3.71 kB | 0 B | | | `dist/examples/example.js` | 683 B | 0 B | | | `dist/portal.js` | 5.39 kB | 0 B | |

compressed-size-action