Closed shawnbot closed 4 years ago
This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.
🔍 Inspect: https://vercel.com/sfds/formio-sfds/kr6m3514p
✅ Preview: https://formio-sfds-git-weird-test-case.sfds.vercel.app
Closing as I've merged this manually in #122.
This is a (manual) re-application the blue background and vertical spacing fixes originally introduced in #109, but without the weird regression documented in #119.
Current status
What this does
Introduces an integration test that simulates the failure condition of the form linked above. I downloaded the JSON from form.io and turned that into a test fixture, then wrote a very basic test that jumps to the third page, simulates clicking the "next" button, and checks that all of the required fields are properly marked as invalid.
Removes blue background from radio, checkbox, and fieldset components; preserves it in address and "well" components; and normalizes vertical spacing within nested components.
Review links
The plan moving forward