Closed aekong closed 3 years ago
This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.
🔍 Inspect: https://vercel.com/sfds/formio-sfds/5sw7pm26o
✅ Preview: https://formio-sfds-git-sg-1235-form-layout-update.sfds.vercel.app
Size Change: +2.13 kB (+2%)
Total Size: 90 kB
Filename | Size | Change |
---|---|---|
dist/formio-sfds.css |
14.3 kB | +280 B (+2%) |
dist/formio-sfds.standalone.js |
70 kB | +1.85 kB (+3%) |
thanks for the review! applied the suggestions for linting errors, will address the other things soon. And yeah, let's sync up on this, I'll set up some time for us
i think that dangling line is because i didn't account for the last nav item 🤦 . should be fixed with this: https://github.com/SFDigitalServices/formio-sfds/pull/149/files#diff-e3adbf2b5c8bb0b30621685b9324d6588b681898cb332272c0a4ae3f910bdb03R62
looks ok now: https://formio-sfds-git-sg-1235-form-layout-update.sfds.vercel.app/examples/review
updates the form layout and navigation, related to https://sfgovdt.jira.com/browse/SG-1235
also allows preview to proxy any url (to allow previews from multidev envs on pantheon)