search

SFDigitalServices / formio-sfds

The form.io theme for sf.gov
https://formio-sfds.herokuapp.com/
MIT License
15 stars 2 forks source link

Translation fixes + tests #151

Closed shawnbot closed 3 years ago

shawnbot commented 3 years ago

This PR adds some more test coverage to our template translation calls and adds missing translations to radio (and "selectboxes") component item labels. This was simply an oversight on my part, and I'd like to follow this up with tests that cover other component templates I might've missed.

150 is related because I've noticed in some cases (I'm still not sure which), the validation error message translations break and we end up with keys like required or pattern rather than the default translations. The generic string tests are meant to catch if we're overwriting our generic string translations from src/i18n/*.json when passing in custom translations, which appears not to be the case.

vercel[bot] commented 3 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/sfds/formio-sfds/oycwarkl8
✅ Preview: https://formio-sfds-git-translation-fixes.sfds.vercel.app

github-actions[bot] commented 3 years ago

Size Change: +20 B (0%)

Total Size: 91.9 kB

Filename Size Change
dist/formio-sfds.standalone.js 68.2 kB +20 B (0%)
ℹ️ View Unchanged | Filename | Size | Change | | |:--- |:---:|:---:|:---:| | `dist/common.css` | 332 B | 0 B | | | `dist/examples.js` | 3.51 kB | 0 B | | | `dist/examples/example.js` | 508 B | 0 B | | | `dist/formio-sfds.css` | 14 kB | 0 B | | | `dist/portal.js` | 5.36 kB | 0 B | |

compressed-size-action