SFDigitalServices / formio-sfds

The form.io theme for sf.gov
https://formio-sfds.herokuapp.com/
MIT License
15 stars 2 forks source link

Add error messages example #158

Closed shawnbot closed 3 years ago

shawnbot commented 3 years ago

@nlsfds and I were trying to sort out how different types of validation error messages show up, so I thought I would add an example for it:

https://formio-sfds-git-error-examples.sfds.vercel.app/examples/error-messages

image

vercel[bot] commented 3 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/sfds/formio-sfds/jms10yj5z
✅ Preview: https://formio-sfds-git-error-examples.sfds.vercel.app

github-actions[bot] commented 3 years ago

Size Change: +6.66 kB (6%) 🔍

Total Size: 98.6 kB

Filename Size Change
dist/examples.js 10.7 kB +7.17 kB (67%) 🆘
dist/examples/example.js 0 B -508 B (0%)
ℹī¸ View Unchanged | Filename | Size | Change | | |:--- |:---:|:---:|:---:| | `dist/common.css` | 332 B | 0 B | | | `dist/formio-sfds.css` | 14 kB | 0 B | | | `dist/formio-sfds.standalone.js` | 68.2 kB | 0 B | | | `dist/portal.js` | 5.36 kB | 0 B | |

compressed-size-action

shawnbot commented 3 years ago

FYI, this size change doesn't affect the bundle that we use on sf.gov. examples.js is only used on example pages:

Size Change: +6.66 kB (6%) 🔍

Total Size: 98.6 kB

Filename Size Change
dist/examples.js 10.7 kB +7.17 kB (67%) 🆘

shawnbot commented 3 years ago

This isn't "done", but I think it's worth including in the 7.0.3 release. We can always add more error message examples! 🚀