SFDigitalServices / formio-sfds

The form.io theme for sf.gov
https://formio-sfds.herokuapp.com/
MIT License
15 stars 2 forks source link

Release 8.0.0 #164

Closed github-actions[bot] closed 3 years ago

github-actions[bot] commented 3 years ago

Pull requests

:bomb: Breaking changes

:rocket: Features

:bug: Bug fixes

:house: Internal

vercel[bot] commented 3 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/sfds/formio-sfds/F4XBNmocYSwd73U4RhRmqNoHV9KW
✅ Preview: https://formio-sfds-git-release-800-sfds.vercel.app

github-actions[bot] commented 3 years ago

Size Change: -2.16 kB (-2%)

Total Size: 87.1 kB

Filename Size Change
dist/common.css 297 B -35 B (-11%) 👏
dist/formio-sfds.css 14.3 kB +300 B (+2%)
dist/formio-sfds.standalone.js 67.1 kB -2.42 kB (-3%)
ℹī¸ View Unchanged | Filename | Size | Change | | :--- | :---: | :---: | | `dist/portal.js` | 5.36 kB | 0 B |

compressed-size-action

shawnbot commented 3 years ago

@aekong I'm sorry this is messy, but there are a couple of things that you need to make sure to do before updating snapshots (or really, even running tests):

  1. npm ci to clear out the node_modules directory and reinstall dependencies, just in case whatever branch you had checked out previously built different versions of dependencies.
  2. npm run build-js to build the new JS bundles, because some of the tests (namely, the snapshot ones) require the built JS directly. (I don't quite remember why, sorry 🙈 )
aekong commented 3 years ago

Thanks! And sorry again for breaking it! 🙇 🙇 🙇