SFDigitalServices / formio-sfds

The form.io theme for sf.gov
https://formio-sfds.herokuapp.com/
MIT License
15 stars 2 forks source link

Implement design system button styles #192

Closed shawnbot closed 3 years ago

shawnbot commented 3 years ago

For DESSYS-85 and the recently discovered issue with form navigation on sf.gov after deploying this change.

Some good URLs to test are:

This is tricky to debug, so in order to test with exactly the same CSS that's on sf.gov I've added a new dynamic CSS endpoint, /sfgov/forms.css, that loads the feedback form, scrapes both stylesheet URLs from the <link> elements and inline <style> contents, then concatenates them all together into this. The upshot is that we can retire the common.css file that used to just import a bunch of static URLs and was hard to keep up-to-date.

Screenshots

A B C D
image image image image
github-actions[bot] commented 3 years ago

Size Change: -138 B (0%)

Total Size: 88.1 kB

Filename Size Change
dist/common.css 0 B -297 B (removed) 🏆
dist/formio-sfds.css 14.1 kB -161 B (-1%)
dist/formio-sfds.standalone.js 67.7 kB +286 B (0%)
dist/portal.js 6.37 kB +34 B (+1%)

compressed-size-action

shawnbot commented 3 years ago

@nlsfds noted on Slack:

One thing I would also like to improve is to make links clickable with the green check if those pages are completed.

I think I've addressed this here!