search

SFDigitalServices / formio-sfds

The form.io theme for sf.gov
https://formio-sfds.herokuapp.com/
MIT License
15 stars 2 forks source link

Sg 1162 #211

Closed c3gabe closed 2 years ago

c3gabe commented 2 years ago

Modifies the "leaving page" alert to trigger only when form has been modified.

github-actions[bot] commented 2 years ago

Size Change: -6 B (0%)

Total Size: 89.3 kB

Filename Size Change
dist/formio-sfds.standalone.js 68.7 kB -6 B (0%)
ℹ️ View Unchanged | Filename | Size | | :--- | :---: | | `dist/formio-sfds.css` | 14 kB | | `dist/portal.js` | 6.65 kB |

compressed-size-action

c3gabe commented 2 years ago

Hi Shawn, I fixed some lint issues but the remaining 2 I'm not sure how to fix Error: 95:3 error 'form' is not defined no-undef Error: 466:10 error 'scrollToTop' is defined but never used no-unused-vars

@shawnbot Using form worked just fine on my local, and scrollToTop was not my creation. I'm not sure how to proceed, can you please advise? Also, local linting failed with "ESLint couldn't find the config "airbnb" to extend from."

shawnbot commented 2 years ago

@c3gabe I'll take a look now. And yes, I'm sorry but I haven't tested this eslint setup with VS Code yet. Let me see if I can get that working while I'm in there.