search

SFDigitalServices / sf-dahlia-pattern-library

Pattern library for SF DAHLIA Housing Portal.
https://sf-dahlia-pattern-library.herokuapp.com/
3 stars 1 forks source link

[pattern library] Fix navbar buttons for Filipino #134

Closed james-wills-sf closed 4 years ago

james-wills-sf commented 4 years ago

#174106809 Related Webapp PR: https://github.com/SFDigitalServices/sf-dahlia-web/pull/1403

Signed out, XL

- 2020-08-13 at 3 16 17 PM - 2020-08-13 at 3 16 47 PM - 2020-08-13 at 3 16 53 PM - 2020-08-13 at 3 16 59 PM

Signed in, XL

- 2020-08-13 at 3 17 20 PM - 2020-08-13 at 3 17 31 PM - 2020-08-13 at 3 17 25 PM - 2020-08-13 at 3 17 12 PM

Signed out, smallest breakpoint that shows navbuttons

- 2020-08-13 at 3 03 43 PM - 2020-08-13 at 3 03 54 PM - 2020-08-13 at 3 21 06 PM - 2020-08-13 at 3 21 01 PM

Signed in, smallest breakpoint that shows navbuttons

- 2020-08-13 at 3 18 03 PM - 2020-08-13 at 3 17 47 PM - 2020-08-13 at 3 17 52 PM - 2020-08-13 at 3 17 58 PM

akegan commented 4 years ago

@james-wills-sf looks wonky for me on the review app (https://dahlia-web-full-pr-1403.herokuapp.com/)

image

james-wills-sf commented 4 years ago

@akegan wow okay, should have tested in chrome. Looking into it

akegan commented 4 years ago

cool, maybe a good example of something we can test on browserstack on edge and ie11 too