SFDigitalServices / sf-dahlia-pattern-library

Pattern library for SF DAHLIA Housing Portal.
https://sf-dahlia-pattern-library.herokuapp.com/
3 stars 1 forks source link

[#150933353] - Styling for button header in accordion #51

Closed chrisdolendo closed 7 years ago

kaptron commented 7 years ago

@chrisdolendo what version of node/npm are you using? I've noticed that when you compile toolkit.css it looks slightly different than mine. If you upgrade to npm >5.0 then it would use the package-lock.json and then presumably our packages/output should line up the same (basically they introduced a functionality like Gemfile.lock in npm 5). I have:

$ node -v
v6.11.1
$ npm -v
5.3.0

see for example mine creates a diff from yours where there is a transition, it no longer includes the webkit vendor prefix:

-  -webkit-transition: opacity 300ms ease-out;
-          transition: opacity 300ms ease-out;
+  transition: opacity 300ms ease-out;
chrisdolendo commented 7 years ago

@kaptron I was wondering about that. Will update my stuff and re-grunt :)

kaptron commented 7 years ago

feature has been accepted/merged in web app, merging this to PL