antsankov commented 8 years ago

What you've done

This is where you list what you worked on. Including a screenshot is best. (REPLACE ME)

Bugs you've encountered

Any bugs that you've encountered (REPLACE ME)

PRs or Issues

Any PRs or Issues that you've made during the week. Links are best.

Brady76 commented 8 years ago

What you've done

Updated the navigation bar, functional & added logout functionality

Added base pages for Profile, RawDump, and Help w/ routes & handlers on back end

Finished response cards: Progress saved forwards and backwards, submit available once all questions answered

Updated color scheme w/ complementary colors, might expand w/ more colors but a bit problematic with MDL, just think it's kind of ugly still imo.

Fixed gulpfile with boilerplate update from Sam

(I left the static page the same but it might need updating, cards are now blue and orange like in previous screenshot which are complimentary colors since they're on opposite sides of the color wheel, but I'm not in love with it)

Bugs you've encountered

Possible Bug: If you have questions of the same type twice in a row, the checkboxes stay in the same state along with possibly the response state that goes in the JSON but I'm having a hard time testing it without a functional survey_creation api

PRs or Issues

https://github.com/SFII/scq/pull/122
https://github.com/SFII/scq/pull/116
https://github.com/SFII/scq/pull/111
https://github.com/SFII/scq/pull/121

Brady76 commented 8 years ago

What you've done

Code cleaning
Documentation/Commenting of all the .jsx files
Navbar update to fix meeting discussion
Addition of react keys, bug fix on cards where question type was the same consecutively
Updated format of primary_affiliation and majors and minors to be consistent and intuitive.

Bugs you've encountered

None this week.

PRs or Issues

https://github.com/SFII/scq/pull/141
https://github.com/SFII/scq/pull/137
https://github.com/SFII/scq/pull/135
https://github.com/SFII/scq/pull/134

wannabeCitizen commented 8 years ago

Nice Brady. Are those navbar links actually linking to anything yet?

Brady76 commented 8 years ago

Yup! Sam had everything templated out so it was really simple making the pages with the same general layout. There's just one drop down menu I missed.

On Thursday, March 3, 2016, Michael Warren Skirpan notifications@github.com wrote:

Nice Brady. Are those navbar links actually linking to anything yet?

— Reply to this email directly or view it on GitHub https://github.com/SFII/scq/issues/123#issuecomment-191864985.

Brady76 commented 8 years ago

What you've done

Survey Creation's up and running, I didn't want to walk all over Carlos's work so I just did Multiple Choice and Single Choice to get him unstuck

Profile Groups, subscribing & viewing current groups (Nico took group creation since I took up helping Carlos)

General bug fixing
There were some edge cases I'd not realized until after doing survey creation, having surveys of one question caused problems with the progress bar which I've changed to fill up as you enter the question as opposed to after you finish it, and I had to include an additional case for the footer so the correct buttons would be enabled/disabled. I also had to change the react keys on question options so that a duplicate option wouldn't have an identical react key which would certainly cause issues