SFII / scq

Our main repo for the SCQ senior project.
8 stars 6 forks source link

Adding documentation #141

Closed Brady76 closed 8 years ago

Brady76 commented 8 years ago

Mostly comments, but also got rid of some redundant code and reorganized dashboard.html to be in line with the other html files using layouts through templates using a react block. Next up will be eliminating the anti patterns in questions.jsx but that could prove tricky so I'll push that till tomorrow.

nicot commented 8 years ago

Looks great Brady, thanks for cleaning this up.

One suggestion, comments like this: https://github.com/SFII/scq/pull/141/files#diff-7c1a5b7dfd8ac14391abc861663d4004R5 are not always necessary.

Sometimes they are very helpful, like in the next comment where you explain where the data is created, but often the code can stand on its own without comments.