search

SFII / scq

Our main repo for the SCQ senior project.
8 stars 6 forks source link

Bug fix #170

Closed Brady76 closed 8 years ago

Brady76 commented 8 years ago

I don't know why because I never changed the state after doing so, but in handleSubmit the keys are deleted before the survey is checked for correctness, if it was incorrect React would fail because the keys were gone once you edited the survey. So I just expanded the scope of the test to check for correctness even before we prune the keys off. I also made it so when the survey submits correctly the page refreshes.
Merge this when you can @CarlosHL or @MCChung303 if it looks good to you.

CarlosHL commented 8 years ago

Ey are you sure with all that code? I was about to ask you for check groups but what you have done seems to add to much complexity... Good point with the change "==" (equal) to "===" (strict equal), I decided to go with strict but after some testing is better equal. @Bradyta

Brady76 commented 8 years ago

Pretty sure, I don't think I changed that much, and I pretty thoroughly tested it before making the PR. I actually didn't know there was a strict equal I thought that was just a typo so I should've asked you about that sorry. I'll make some inline comments to help explain the code

CarlosHL commented 8 years ago

Not worries! I was going to check your code and you usually check mine so I don't thing changing stuff will be a problem. Merged