search

SFII / scq

Our main repo for the SCQ senior project.
8 stars 6 forks source link

Basic Testing Implementation (ready for merge) #187

Closed Brady76 closed 8 years ago

Brady76 commented 8 years ago

Testing is done for all but a few react classes that won't appear unless I miss with React simulation (unfortunately I'm out of time to be working on this).
Run make test-js to run the tests, make sure you run npm install again as I've updated our dependencies.
This is probably my last PR until the expo. :)

untra commented 8 years ago

Either remove the try catches or do something in the catch. Error Hiding is an antipattern. If your code works because you can throw away errors if they happen, your code doesn't work.

Brady76 commented 8 years ago

I was on the way out and just wanted to get what I had up but the purpose of them was just to ignore the line of code while testing. My idea is to have a global testing variable but I'm otherwise just seeking creative input before I make it back to my laptop tonight, understandably I wasn't going to allow those to remain regardless. There are just certain operators and such that can't translate to regular JavaScript and I'm trying to find the best way to jump through those hoops.

On Friday, April 22, 2016, Samuel Volin notifications@github.com wrote:

Either remove the try catches or do something in the catch. Error Hiding is an antipattern. If your code works because you can throw away errors if they happen, your code doesn't work.

— You are receiving this because you modified the open/close state. Reply to this email directly or view it on GitHub https://github.com/SFII/scq/pull/187#issuecomment-213593653