SFII / scq

Our main repo for the SCQ senior project.
8 stars 6 forks source link

Make a dynamic faculty/student registration page #66

Closed wannabeCitizen closed 8 years ago

wannabeCitizen commented 8 years ago

Should get registration questions related to faculty, student, or both.

@untra @sungbae -- go to down!

sungbae commented 8 years ago

So Sam taught me how to make this dynamic, but the only problem is that I don't know what specific questions to separate for student and faculty. I'll just work on styling for now.

wannabeCitizen commented 8 years ago

Well there should be information that only faculty could answer (such as, what do you teach) and ones for students (such as, what classes do you take) On Jan 19, 2016 9:14 PM, "Sung Bae" notifications@github.com wrote:

So Sam taught me how to make this dynamic, but the only problem is that I don't know what specific questions to separate for student and faculty. I'll just work on styling for now.

— Reply to this email directly or view it on GitHub https://github.com/SFII/scq/issues/66#issuecomment-173061882.

wannabeCitizen commented 8 years ago

I imagine if you just think on it a bit, you'll find the questions appropriate. On Jan 20, 2016 12:10 PM, "Michael Skirpan" doorsofskirpan@gmail.com wrote:

Well there should be information that only faculty could answer (such as, what do you teach) and ones for students (such as, what classes do you take) On Jan 19, 2016 9:14 PM, "Sung Bae" notifications@github.com wrote:

So Sam taught me how to make this dynamic, but the only problem is that I don't know what specific questions to separate for student and faculty. I'll just work on styling for now.

— Reply to this email directly or view it on GitHub https://github.com/SFII/scq/issues/66#issuecomment-173061882.

sungbae commented 8 years ago

Almost done with this PR #74... Just have a couple of issues.

  1. checking departments/primary_affiliation as is_list is complaining from the registration page
  2. dynamic additions of text box not saving into the data base
sungbae commented 8 years ago

Sorry this is taking longer than what I have anticipated. I've completed making a larger textbox for courses/departments. I've fixed the is_list error. Now I'm just cleaning up the data displayed on the user info/update page. I would love to code review with @untra after I finish my changes though.

sungbae commented 8 years ago

line 18: user_update.html

  {% for user_gender in user_genders %}
    {% if user_gender %}
      <option selected value="{{ user_gender }}">{{ user_gender }}</option>
    {% else %}
      <option value="{{ user_gender }}">{{ user_gender }}</option>
    {% end %}
  {% end %}
sungbae commented 8 years ago

Change this template into java script?