search

SFML / CSFML

Official binding of SFML for C
https://www.sfml-dev.org
Other
342 stars 121 forks source link

Revert "Temporarily lock SFML revision used in CI" #265

Closed ChrisThrasher closed 3 weeks ago

ChrisThrasher commented 3 weeks ago

This reverts commit 36a6e7c5a617b3f6cdb6bac9a9613e516ea6ba6e.

Now that SFML 3's API is mostly stable we no longer need to lock down the specific commit hash.

ChrisThrasher commented 3 weeks ago

https://github.com/SFML/CSFML/actions/runs/10464568981/job/28978624152?pr=265#step:9:189

This error has happened before and it's been fixed by rerunning the job. I now see it's a race condition between compiling Catch2 and copying its DLLs. I fixed it in another commit in this PR.

kimci86 commented 3 weeks ago

I believe the build error is caused by several copies of the same file running at the same time.

One way to solve it as this CMake documentation example may suggest is to do the copy in a single custom target. I tried to implement this here: https://github.com/SFML/CSFML/compare/master...kimci86:CSFML:bugfix/test_dll_copy_concurrency I am not sure how to get rid of the stamp file I am using in that branch.