search

SFML / SFML-Buildbot

SFML's Buildbot configuration
7 stars 4 forks source link

Run tests with xvfb-run on Linux #38

Closed ChrisThrasher closed 1 year ago

ChrisThrasher commented 1 year ago

Fixes build errors in https://github.com/SFML/SFML/pull/2302.

ChrisThrasher commented 1 year ago

In https://github.com/SFML/SFML/pull/2302 I added a new option called SFML_ENABLE_OPENGL_TESTS which enables tests that require a display. We could just set this option to OFF for all extended CI pipeline jobs. This is overkill but honestly not a big deal since we get great coverage running these tests on all possible jobs in the non-extended CI pipeline. That would let us wrap up this issue fairly quickly and move onto actually writing the tests we want to write.

eXpl0it3r commented 1 year ago

I've already gotten xvfb installed on Debian, so builds on that and Windows should be fine.
I think for the Raspberry Pi I didn't manage to get it working either, so I wouldn't mind not running it there.

binary1248 commented 1 year ago

Display tests on Linux (Debian) are enabled by d0e9c35aac87a6d40c1498fd13ce4be171a19068. We still shouldn't attempt to run the display tests on anything else than that (Android, FreeBSD, etc.). The only safe workers to run display tests on are Windows, macOS and Debian right now.

binary1248 commented 1 year ago

The whitelist here should be adjusted accordingly to enable by default only on Windows, macOS and Linux.