SFML / SFML-Website

Repository for the SFML website.
Other
22 stars 35 forks source link

Replace `‑` with `-` #155

Closed andraantariksa closed 1 year ago

andraantariksa commented 1 year ago

https://github.com/SFML/SFML-Website/blob/0f05d6274b9bc6f867f88386d45cbcddf686eb63/tutorials/2.5/compile-with-cmake.php#L355

Why would the website use ‑ to replace -?

I had a hard time after copy pasting a text from this website https://stackoverflow.com/questions/59573574/how-do-i-use-sfml-with-cmake-fetchcontent#comment105349020_59584360

eXpl0it3r commented 1 year ago

It's a non breaking dash, so I guess the idea was that you won't ever get something like the following rendered:

... sfml-system sfml-
window sfml-network ...

However as you pointed out when copy pasting it could lead to issues, so might make sense to change it.

Do you want to provide a pull request?

eXpl0it3r commented 1 year ago

image

Hmm maybe we just need to add some min-width styling now 🤔

andraantariksa commented 1 year ago

120px of min-width looks fine for me

image

www sfml-dev org_tutorials_2 5_compile-with-cmake php(iPhone 12 Pro)

eXpl0it3r commented 1 year ago

Sounds good to me, do you want to PR it? 🙂