search

SFML / imgui-sfml

Dear ImGui backend for use with SFML
MIT License
1.08k stars 163 forks source link

Make a new release (2.6) #234

Closed eliasdaler closed 10 months ago

eliasdaler commented 1 year ago

Nothing major, but a small few fixes were added here and there.

Also need to notify vcpkg and Conan precipice maintainers that the repo address has changed so that they can update it.

adrianboyko commented 1 year ago

Would it be a good time to deal with recent deprecations added around Dear ImGui version 1.88? Try:

  #define IMGUI_DISABLE_OBSOLETE_FUNCTIONS
  #define IMGUI_DISABLE_OBSOLETE_KEYIO
eliasdaler commented 1 year ago

It's always a good time to deal with them. PRs are appreciated. :)

adrianboyko commented 1 year ago

I'd help out if it weren't for the fact that I've only just started using ImGui so my experience level is dangerously low :(

cosmicr commented 1 year ago

Would also love to see a new release. There have been hundreds of changes and improvements to imgui since version 1.80 - the version imgui-sfml uses. They're now at 1.89.3.

eliasdaler commented 1 year ago

@cosmicr FYI, imgui-sfml doesn't depend on a specific version of Dear ImGui. You can use the latest version if you want to. If you use Conan/vcpkg package, you should ask maintainers to update the dependencies.

cosmicr commented 1 year ago

@eliasdaler Yeah I would do that but my own project is using CMake to fetch imgui-sfml, which in turn fetches the 1.80 version of imgui: https://github.com/SFML/imgui-sfml/blob/f0d8f72f073b367e9506b8794158cc91f015252e/CMakeLists.txt#L60

I guess I could make a pr for changing this, or there might be another way to get the latest imgui version first, but I'm terrible at writing cmake files lol.

I'm happy to wait for a new version to reference the latest imgui

eliasdaler commented 1 year ago

This only specifies the minimal version of Dear ImGui which can be used.

It doesn't fetch anything - you still need to tell ImGui-SFML where to find Dear ImGui and it will happily use whatever version you provide as long as it's >=1.80.

Of course, I'm now not sure which is the true minimum version that can work with ImGui-SFML, but I don't want to annoy people and make them update Dear ImGui along the ImGui-SFML all the time.

cosmicr commented 1 year ago

Doh you are right, I had forgotten I included a FetchContent_Declare in my cmake to download imgui - I'm already using v1.89 lol. For some reason I thought the imgui-sfml cmake file was magically downloading it. Sorry for wasting your time.

eliasdaler commented 1 year ago

No problem :)

ChrisThrasher commented 1 year ago

Now is a great time for a 2.6 release now that SFML 2.6 is out.

ChrisThrasher commented 10 months ago

https://github.com/SFML/imgui-sfml/releases/tag/v2.6