SFML / imgui-sfml

Dear ImGui backend for use with SFML
MIT License
1.13k stars 169 forks source link

Link to SFML 3's new target names #243

Closed ChrisThrasher closed 1 year ago

ChrisThrasher commented 1 year ago

The only targets exported from SFML 3's config module are of the form SFML::Graphics. If you call find_package(SFML 3 REQUIRED), there will be no target named sfml-graphics like there is in SFML 2. This particularly library may exist in the form libsfml-graphics.so or something similar but that shared object is not a CMake target and thus doesn't carry information like include directories or compile definitions. If we're going to keep supporting SFML 2 and 3 on one branch then we need to add a new conditional to the build that selects the right target names.

A cleaner solution is to go ahead and branch off for ImGui-SFML 3/SFML 3 so that such a conditional isn't required.

ChrisThrasher commented 1 year ago

Fixed in master