Revert enabling "warnings as errors" in the default build

SFML / imgui-sfml

Dear ImGui backend for use with SFML

MIT License

1.08k stars 163 forks source link

Revert enabling "warnings as errors" in the default build #248

Closed oprypin closed 11 months ago

oprypin commented 11 months ago

Following up and reverting part of https://github.com/SFML/imgui-sfml/pull/246

ChrisThrasher commented 11 months ago

This is overkill. Remove -Werror if you're worried about that. Better yet add a new option like SFML does that lets users disable warnings as errors. It's a very bad idea to entirely remove compiler warnings because it's increasing the chances of bugs or other code smells getting in. It's not feasible to write high quality C++ without a solid set of compiler warnings checking your work at all times.

ChrisThrasher commented 11 months ago

https://github.com/SFML/imgui-sfml/commit/7da7dfe10ee27c48878195940a5355eed60e3104

Here's the fix you actually want. Our list of warnings is only going to grow so it's good to have this option for those who for whatever reason are seeing a warning that isn't already caught in CI.

oprypin commented 11 months ago

I want to make that release happen, and take no risks in it.

ChrisThrasher commented 11 months ago

Merging this PR just added a lot more risk to all future development

ChrisThrasher commented 11 months ago

See https://github.com/SFML/imgui-sfml/pull/251