search

SFML / imgui-sfml

Dear ImGui backend for use with SFML
MIT License
1.15k stars 172 forks source link

fix: account for rename to `getNativeHandle` #256

Closed JohelEGP closed 1 year ago

JohelEGP commented 1 year ago

Hmm... this fails because SFML is not up-to-date. And the README claims to support SFML >= 2.5.0. These seem to be at odds.

ChrisThrasher commented 1 year ago

These seem to be at odds.

The SFML API in question was changed yesterday. Nothing is at odds, it just take a little time for SFML 3 API changes to get fixed this project.

You're using SFML 3 but the SFML 2 API has not changed. Your PR needs to do what we do elsewhere in ImGui-SFML and use the preprocessor to change which file gets called depending on whether SFML 2 or 3 is being used. I can do this myself but not until later this week.

JohelEGP commented 1 year ago

Thank you. I've done that.

ChrisThrasher commented 1 year ago

Fixed in master