SFML / imgui-sfml

Dear ImGui backend for use with SFML
MIT License
1.08k stars 163 forks source link

Manual integration into project on readme need updating? #269

Closed Jamie-Troup closed 5 months ago

Jamie-Troup commented 7 months ago

Hello,

Just wondered if this section of the readme.md,

Integrating into your project manually

Needed a line saying Add imgui-SFML_export.h to your build/project? I'm only saying this because when copying the contents of imconfig-SFML.h into imconfig.h it copies the line #include "imgui-SFML_export.h". Without adding imgui-SFML_export.h alongside imconfig.h this lead to a compiler error when building my project.

I have only just started using SFML and ImGui, so please forgive me if this is completely off the mark/wrong. Thanks!

eliasdaler commented 6 months ago

Doesn't this line covers this?

Add a folder which contains imgui-SFML.h to your include directories

So, if you add imgui-sfml's dir to your include directories, imconfig-SFML.h will be able to find imgui-SFML_export.h too.

Jamie-Troup commented 5 months ago

Thank you, as you may have guessed I am a bit of a c++ newbie (especially with tools like C make which I was using) so yeah that does cover it (I just didn't know!).

I made sure the include directories in my make file were correctly pointing to the SFML files and it has all worked so far. Cheers