search

SFML / imgui-sfml

Dear ImGui backend for use with SFML
MIT License
1.15k stars 172 forks source link

Remove use of obsolete ImGui functions - v1.89 #303

Closed Legulysse closed 3 weeks ago

Legulysse commented 3 weeks ago

This PR contains a migration commit to allow imgui-sfml to be compiled with the flag IMGUI_DISABLE_OBSOLETE_FUNCTIONS. Target imgui version : 1.89

Edit: this PR is tied to this ticket : https://github.com/SFML/imgui-sfml/issues/301

ChrisThrasher commented 3 weeks ago

Thanks! I need a little more time to figure out how I want to enforce this in CI but once I do that I can get this merged.

Legulysse commented 3 weeks ago

Nice ! To be clear, this update will not impact people already using 1.89, it will only make it available for people using the stricter compilation with the deprecation flag.

Legulysse commented 3 weeks ago

Seems safer this way to me ! And it allows the library and its users to move forward alongside imgui's future versions. (you left a typo, using "obsolute" instead of "obsolete" in the cmake doc)

ChrisThrasher commented 3 weeks ago

Thanks for your help on this. I'll get this merged into master as well. I'm still not sure what to do about future ImGui versions which make even more things obsolete but we can hopefully figure something out. In the meantime I hope this makes your life a little easier.

Legulysse commented 3 weeks ago

@ChrisThrasher Thank you for your work ! I guess I should close the other PR I made ? Dont hesitate if you want to discuss those concerns further on the associated issue, or if you want me to provide PRs for those other updates later on.