SFOE / OGD_qualitychecks

Automated pipeline to check OGD data quality using Frictionless
0 stars 0 forks source link

Step 0: setup #2

Open AFoletti opened 1 year ago

AFoletti commented 1 year ago

Goal: have a properly setted up work environment and developing process

What I would like is to use this very small project as an exercice for you to use Git(hub) with proper commits, branches, pull requests (PR), code reviews and merges. Feel free to ask for details and/or read a guide or two about the mechanics.

The process how I foresee it (open for discussion in this ticket):

  1. You handle the tickets one after the other, either following my numbering of proposing a new order if you find it better
  2. For each ticket, you write your code and commit it regularly on a meaningfully named branch using meaningful commit titles (short) and comments (longer).
  3. Once happy with the results and you consider the ticket to be solved, you post a PR and assign it to me, mentioning the ticket it will solve (use a proper github link)
  4. I (and possibly Martin) review the code, make suggestion or comments
  5. Once the code is OK, you do a very short (5 minutes) live demo, demonstrating the feature
  6. The code is accepted (by me and/or Martin) and then merged into master (by yourself)

Deliverables for this ticket:

aresssera commented 1 year ago

remark: I do not intend to save the names of the files contained in the staging directory in a separate CSV file. For now, I am only doing this for testing purposes. However, if the python script is run on the @listFileNames branch, it will only succeed if the new file is different from the old one.