search

SFTtech / openage

Free (as in freedom) open source clone of the Age of Empires II engine 🚀
http://openage.dev
Other
12.6k stars 1.11k forks source link

Most unit creation/destruction sounds are -1 #102

Closed franciscod closed 9 years ago

franciscod commented 9 years ago

Code to test: https://github.com/franciscod/openage/compare/debug-sounds

I don't know if its due to my assets utterly phailing or happens to everyone, but here's my output with that code:

$ make run | grep sound_cr

MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:   291, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:   291, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:   337, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:   291, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:   291, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:   337, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:   337, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
MSG      sound_creation0:    -1, sound_creation1:    -1, sound_dying:    -1
goto-bus-stop commented 9 years ago

The building units with sound_creation0 are: TREBU, PTREB, HBNB, HGOS, PMANG, HGOSP, HBNBP

TREBU is the unpacked Trebuchet, PTREB is a packed Trebuchet.

I think Buildings don't use the sound_creation, but instead sound_selection for when they're built. The sound_creation stuff is used by non-building units (Archer, Packed Trebuchet, …).

franciscod commented 9 years ago

nice find! :D

franciscod commented 9 years ago

implemented with sound_selection on #108, thanks @goto-bus-stop :grinning: