search

SFTtech / openage

Free (as in freedom) open source clone of the Age of Empires II engine 🚀
http://openage.dev
Other
12.63k stars 1.11k forks source link

openage should work without a terminal available #106

Closed boombatower closed 9 years ago

boombatower commented 9 years ago

Currently it appears that if one starts openage without a terminal it does not work. For example using a .desktop file without setting

Terminal=true

the game will not load. Making that change and all is happy.

TheJJ commented 9 years ago

The game just spams output to stdout, apart from the terminal demo, i don't see any reason why the program should relay on the terminal. Any idea why the terminal is required somehow?

franciscod commented 9 years ago

maybe the termios settings on fds.cpp?

franciscod commented 9 years ago

i'll take a shot on this

franciscod commented 9 years ago

umm, if i doubleclick openage on my file manager after this fix https://github.com/franciscod/openage/tree/without-terminal it runs okay!

boombatower commented 9 years ago

hmmm

franciscod commented 9 years ago

demo: https://github.com/franciscod/openage/tree/desktopfile-demo

navigate to openage/etc and doubleclick openage.desktop

the only error that desktop-file-validate throws is because of the relative paths lol

zuntrax commented 9 years ago

I created a wrapper script that launches openage with the data parameter and started it using dmenu. That worked fine. Keep in mind that it might take a while until the map is properly rendered, see #70.

boombatower commented 9 years ago

Hmm, clicking on openage.desktop does not work with Terminal option removed or set to false.

boombatower commented 9 years ago

Either way seems to be fixed by dropping ~/ on path...appears .desktop files default to working dir of current users home directory...which is exactly what we want.

Probably still want terminal set to true while in early dev stages since output may be useful? Easier than asking people to rerun and recreate bugs.

boombatower commented 9 years ago

Still not sure exactly what causes this, to only occur with .desktop file. seems like something to do with ~/