search

SFTtech / openage

Free (as in freedom) open source clone of the Age of Empires II engine 🚀
http://openage.dev
Other
12.63k stars 1.11k forks source link

Add clang-tidy to buildsystem checks #1060

Open Vtec234 opened 5 years ago

Vtec234 commented 5 years ago

clang-tidy can detect lots of C++ programming and style errors, so it would be worthwile to have it included in make check. To do so, a Python module invoking it should be added to buildsystem.codecompliance.

mcdermott111 commented 2 months ago

I would be interested in picking up this issue

heinezen commented 2 months ago

@mcdermott111 You are very welcome to do that :)

mcdermott111 commented 2 months ago

What is the best way to decide which clang-tidy errors to be checking for. I think it would be unnecessary to have every single error turned on. The following are the set of errors I was thinking of including so far: clang-analyzer, bugprone, concurrency, performance and their respective sub-errors. Here is the list of all clang-tidy errors: https://clang.llvm.org/extra/clang-tidy/checks/list.html

heinezen commented 2 months ago

@mcdermott111 I think these are good choices. We can always be more thorough later if we want.