Open heinezen opened 3 years ago
When you say
most of the runtime errors are actually lookup errors
Are those errors code defects, or just because the user does not have the correct AoE2 assets?
Most of them are code defects or missing implementations, e.g.
KeyError
should be caught and raise a NotImplementedError
.The correct AoE2 assets should be detected before the conversion starts.
Hi all! I'm a first time contributor and I am going to try to solve this issue. Very new to open source contributing but hoping I can help here!
@tsherman181 Let us know if you have any problems!
Hi, could I take this up, please?
@anupriyakkumari Hey yes this is free for implementation :)
Required skills: Python
Difficulty: Medium
In AoE2's
.dat
format most associations and assignments of properties are done by IDs (e.g. unit has ability with ID X). The openage converter uses these IDs to lookup the associated openage API property and then map the values from AoE2's.dat
structure to the corresponding API object's member values. In short, every property from AoE2 needs to be manually mapped to an openage API property. As such, most of the runtime errors are actually lookup errors (usually Python'sKeyError
) that occur when an AoE2 property was not mapped to an openage API property.The goal of this task is to make these errors more informative by catching the generic
KeyError
from Python and re-raising it with a better message. For example, we can improve the error message by specifying:Example
generic message:
better message:
Use try-except statement where these lookups could be thrown. Remember to use
raise ... from
to preserve the stack trace of the initialKeyError
.Further reading: