SFTtech / openage

Free (as in freedom) open source clone of the Age of Empires II engine 🚀
http://openage.dev
Other
12.68k stars 1.12k forks source link

Fix version tag regex failure when HEAD is tagged #1583

Closed heinezen closed 11 months ago

heinezen commented 11 months ago

Our buildsystem expects version tags in the format v1.2.3-4-g00abcdef (tag + commit distance to tag + commit hash). However, since https://github.com/SFTtech/openage/pull/1576 we call git describe --tags. When HEAD is tagged, this command only outputs the tag and omits commit distance and commit hash (only v1.2.3 is returned). This results in a configure failure since our regex cannot match the version format in this case.

This PR switches the version fetch command to git describe --tags --long, so that the long format is always used.