SFTtech / openage

Free (as in freedom) open source clone of the Age of Empires II engine 🚀
http://openage.dev
Other
12.51k stars 1.11k forks source link

Drag Selection #1603

Closed heinezen closed 5 months ago

heinezen commented 7 months ago

Depends on https://github.com/SFTtech/openage/pull/1550

Adds drag selection to the possible inputs.

TheJJ commented 5 months ago

has merge conflicts :) another design point: when units die during being selected, intuitively managing and activating the selected unit's status seems better placed at the hud layer. otherwise the dieing must influence the selectability as simulated unit state, instead of the selectability being a flag & then-visible unit data drawn in the hud

heinezen commented 5 months ago

merge conflicts are fixed :)

heinezen commented 5 months ago

another design point: when units die during being selected, intuitively managing and activating the selected unit's status seems better placed at the hud layer. otherwise the dieing must influence the selectability as simulated unit state, instead of the selectability being a flag & then-visible unit data drawn in the hud

Also relevant for the input layer since the selection queue for the controller resides there. This back propagation of the unit state is a bit hard to do across thread boundaries. We can probably manage that via another interface to the presenter though.